Remove undocumented and uncontrollable WiFi RSSI filter. #5393
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit d15e1b0 [1] in the 2.0.0 pull request espressif#4996 introduced a filter to connect only to WiFi networks with a RSSI of -75 or better. This results in strage behaviour, as a scan still shows networks, that can't be connected to, even though with older versions, connecting to those networks was possible and the connection (albeit slow) was stable. Remove the RSSI filter for now by setting the threshold to -127, i.e. the lowest possible value. Maybe in the future the filter threshold could be exposed to users, to allow filtering out nearly unreachable networks. [1] github.com/espressif/pull/4996/commits/d15e1b0
|
|
igrr
approved these changes
Jul 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit d15e1b0e in the 2.0.0 pull request #4996 introduced a filter to connect only to WiFi networks with a RSSI of -75 or better. This results in strange behavior, as a scan still shows networks, that can't be connected to, even though with older versions, connecting to those networks was possible and the connection (albeit slow) was stable.
Remove the RSSI filter for now by setting the threshold to -127, i.e. the lowest possible value. Maybe in the future the filter threshold could be exposed to users, to allow filtering out nearly unreachable networks.